Date.renderCalendar method might be a little bit too special

[tobi]

I am not sure about it but the Date.renderCalendar method is pretty tricky, not only in terms of code.

As far as I can see it needs a HopObject collection as argument which itself is grouped by date in a variable format. Furthermore, it's using the jala.util.getDateSymbols method which I just have thrown out from the trunk...

What do you consider?

[robert]

Reg. the prerequisites of this method (grouped collection, the format of the groupby-column): That's something i personally can live with, as i currently have no idea how a more abstract way of rendering a calendar based on a HopObject? collection should look like.

Reg. getDateSymbols: According to a quick test this doesn't cost that much that caching is a must, so i'd create a new instance of DateFormatSymbols? in every call of renderCalendar.

[tobi]

+1 for adding the instance of DateFormatSymbols where necessary.

What about a calendar that is based on an URL path (e.g. via getChildElement) like "/2007/02/24"? Is it possible to render this with the current method?

[robert]

With the new calendar implementation [126] most (if not all) of the restrictions are gone, so i'm closing this ticket.